backend start script: check ulimit and increase soft limit if possible #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this code would be a good place to document why we need to increase the limit. |
I added a docstring to the |
maringuu
reviewed
Jul 16, 2024
src/start_fact_backend.py
Outdated
Comment on lines
118
to
124
| """ | ||
| Each process has a hard limit and a soft limit for the maximum number of files opened at the same time. Since | ||
| FACT makes extensive use of multiprocessing features, it uses up a lot of those file descriptors and if we run | ||
| out, this raises an OSError. To mitigate this, we try to increase the soft limit and print a warning if the | ||
| hard limit is low. With the default configuration, FACT uses about 560 file descriptors (and potentially many | ||
| more if you crank up the worker counts). | ||
| """ |
There was a problem hiding this comment.
Can specify which multiprocessing features use file descriptors?
While I know that its queues, I would not expect the average reader to think of queues when thinking about multiprocessing.
Also, can you document the calculation that lead to 560 descriptors by default?
There was a problem hiding this comment.
I extended the docstring quite a bit and added information on how the FDs are distributed
maringuu
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.